chore!: Kill legacy Vertical/Horizontal drag detectors - #3993
Draft
luanpotter wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy game-level vertical and horizontal drag detector APIs ahead of Flame 2.0.
Changes:
- Removes detector mixins, gesture registration, exports, and hit-testing support.
- Deletes obsolete detector tests.
- Adds migration guidance and updates gesture documentation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/flame/lib/src/gestures/detectors.dart |
Removes legacy detector mixins. |
packages/flame/lib/src/game/game_widget/gesture_detector_builder.dart |
Removes recognizer registration. |
packages/flame/lib/src/game/flame_game.dart |
Updates game-level event hit testing. |
packages/flame/lib/events.dart |
Removes public exports. |
packages/flame/test/gestures/detectors_test.dart |
Removes detector unit tests. |
packages/flame/test/game/game_widget/game_widget_drag_test.dart |
Removes widget integration tests. |
doc/flame/migration.md |
Documents migration alternatives. |
doc/flame/inputs/gesture_input.md |
Removes obsolete API documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kill legacy Vertical/Horizontal drag detectors
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?