Add low-overhead GPU progress heartbeat monitoring - #1243
Open
lzy-edu wants to merge 9 commits into
Open
Conversation
…#1240) Add standard Apache 2.0 copyright header (Copyright 2026 FlagOS Contributors) to all source files. - **703 files** stamped with Apache 2.0 headers - **80 files** with upstream copyright (HuggingFace, Physical Intelligence, NVIDIA) — left untouched - **104 files** with other licenses (51 MPL, 41 proprietary, 10 MIT, 2 BSD) — third-party/upstream code - **31 files** skipped by rule — binary, JSON, etc. This PR was written in part with the assistance of generative AI.
lzy-edu
requested review from
aoyulong,
heavyrain-lzy and
zhaoyinglia
as code owners
July 21, 2026 08:53
…. 2026/7/21 (flagos-ai#1244) <!-- Copyright 2026 FlagOS Contributors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> ### PR Category <!-- One of [ Train | Inference | Compress | Serve | RL | Core | Hardware | CICD | Tools | Others ] --> [CICD] ### PR Types <!-- One of [ User Experience | New Features | Bug Fixes | Improvements | Performance | Breaking Change| Deprecations | Test Case | Docs | Others ] --> Test Case ### PR Description <!-- Describe what you’ve done --> update golden value of functional_test hetero_train and train.
### PR Category <!-- One of [ Train | Inference | Compress | Serve | RL | Core | Hardware | CICD | Tools | Others ] --> Train ### PR Types <!-- One of [ User Experience | New Features | Bug Fixes | Improvements | Performance | Breaking Change| Deprecations | Test Case | Docs | Others ] --> Others ### PR Description <!-- Describe what you’ve done --> Update qwen3vl for the current `Megatron-LM-FL` and add functional tests.
…#1242) These data files are compared against test outputs line-by-line and cannot contain license headers — adding them broke CI functional tests (e.g., inference/qwen3/4b_tp2). ## Files fixed (7) | File | |---| | inference/deepseek_r1_distill_qwen/results_gold/7b_tp2 | | inference/deepseek_r1_distill_qwen_flaggems/results_gold/7b_tp2 | | inference/qwen3/results_gold/4b_tp2 | | inference/qwen3/results_gold/4b_tp2_ascend | | inference/qwen3_flaggems/results_gold/4b_tp2 | | inference/robobrain2/results_gold/7b_tp2 | | inference/robobrain2_flaggems/results_gold/7b_tp2 | The one JSON gold file (`rl/qwen2_5/results_gold/0_5b.json`) was not affected — JSON doesn't support comments so the header was never added there. Closes flagos-ai#1241's inference test failure. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: zhaoyingli <86812880+zhaoyinglia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Train
PR Types
New Features
PR Description
This PR adds a standalone, low-overhead GPU heartbeat monitoring capability for distributed training.
The main changes include:
nvidia-smi.The heartbeat distinguishes between:
Usage
Enable
heartbeatunderexperiment.runnerin the training configuration:After enabling the heartbeat, start the FlagScale training task with the existing launch command. No additional build step or separate monitoring command is required.
The runner automatically:
Results
Heartbeat monitoring results are written to:
The expected behavior is:
alive, and its GPU training progress is reported asprogressing. No timeout finding is generated.exited, and its GPU progress is reported ascompleted.rank_process_heartbeat_timeoutfinding is recorded.gpu_progress_timeoutfinding is recorded.For example, when a rank remains alive but its training progress stalls,
findings.jsonlcontains a record similar to:{ "finding_type": "gpu_progress_timeout", "rank": 1, "process_liveness": "alive", "gpu_progress": "stalled", "reason": "rank_alive_but_gpu_progress_not_advancing" }These results make it possible to distinguish a rank process that has become unresponsive from a live rank whose GPU training progress has stalled, while also correlating the issue with optional GPU hardware health information.