Feature: Exchange rate addition by fivetran-avinash · Pull Request #223 · fivetran/dbt_quickbooks

fivetran-avinash · 2026-08-29T01:09:48Z

PR Overview

Package version introduced in this PR:

1.10.0

This PR addresses the following Issue/Feature(s):

GA-1032740

Summary of changes:

Bringing in exchange rate data, as well as additional variable support to grab the reporting date for the balance sheet and general ledger by period converted amounts.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

Resolves conflicts in dbt_project.yml/integration_tests/dbt_project.yml (kept 1.10.0), account_data.csv (combined both branches' new seed accounts), and CHANGELOG.md (kept newest-first order: 1.10.0, 1.9.2, 1.9.1).

Merge branch 'feature/exchange-rate' of https://github.com/fivetran/dbt_quickbooks into feature/exchange-rate

fivetran-jamie

Looks good, just some doc-related comments

fivetran-jamie · 2026-09-11T14:25:16Z

    type: string
    value: ""
-    description: "The primary reporting currency, use the same 3-letter ISO currency code (e.g., USD, EUR, GBP, CAD) that appears in your QuickBooks `currency_id` field. Relevant for organizations with multiple currencies, this field defaults to an empty string; when not set, the package applies exchange rate conversions to all transactions, regardless of currency."
+    description: "The primary reporting currency, use the same 3-letter ISO currency code (e.g., USD, EUR, GBP, CAD) that appears in your QuickBooks `currency_id` field. Relevant for organizations with multiple currencies, this field defaults to an empty string; when not set, the package applies exchange rate conversions to all transactions, regardless of currency. Required if `using_report_date_fx_conversion` is enabled."


Since this description is only surfaced in Quickstart, I'd recommend referencing the display_name of using_report_date_fx_conversion, as this is what customers will see in the UI

Good catch, updated

fivetran-jamie · 2026-09-11T14:25:41Z

+  using_report_date_fx_conversion:
+    type: boolean
+    value: false
+    description: "Enable to revalue foreign-currency balance sheet accounts using the exchange rate as of the report date, matching how QuickBooks Online calculates balance sheet conversions. Requires `quickbooks__home_currency` to also be set; without it, the exchange rate lookup cannot resolve and this feature has no effect."


Similar comment about using the display name of quickbooks__home_currency instead

fivetran-jamie · 2026-09-11T14:34:22Z

+| Data Model(s) | Change type | Old | New | Notes |
+| ---------- | ----------- | -------- | -------- | ----- |
+| `quickbooks__general_ledger_by_period`, `quickbooks__balance_sheet` | Opt-in calculation change for `converted_amount` fields |  Converted balance summed from each transaction's own transaction-date exchange rate | For balance sheet accounts, re-converts the native `period_ending_balance` using the exchange rate as of the period's last day | Opt-in via the new `using_report_date_fx_conversion` variable (default `false`); falls back to the legacy method if disabled or if no matching exchange rate is found. No existing customer is affected unless this variable is enabled. |
+| `stg_quickbooks__exchange_rate` | New model | |  | Brings in the new `EXCHANGE_RATE` source table so historical exchange rates can be looked up by date and currency pair. Consumed by `int_quickbooks__general_ledger_balances` to look up the report-date rate for the opt-in conversion described below. |


Should probably include _tmp as well

fivetran-jamie · 2026-09-11T14:41:17Z

+            first_value(period_ending_balance_starter) over (partition by gl_partition {{ fivetran_utils.partition_by_source_relation(package_name='quickbooks') }}
+            order by period_last_day rows unbounded preceding)) as period_beginning_balance_final,
+        coalesce(period_ending_balance_starter,
+            first_value(period_ending_balance_starter) over (partition by gl_partition {{ fivetran_utils.partition_by_source_relation(package_name='quickbooks') }}
+            order by period_last_day rows unbounded preceding)) as period_ending_balance_final,
+        coalesce(period_beginning_converted_balance_starter,
+            first_value(period_ending_converted_balance_starter) over (partition by gl_converted_partition {{ fivetran_utils.partition_by_source_relation(package_name='quickbooks') }}
+            order by period_last_day rows unbounded preceding)) as period_beginning_converted_balance_final,
+        coalesce(period_ending_converted_balance_starter,
+            first_value(period_ending_converted_balance_starter) over (partition by gl_partition {{ fivetran_utils.partition_by_source_relation(package_name='quickbooks') }}


I see that period_beginning_converted_balance_final uses gl_converted_partition as a partition while the others use gl_partition -- should these be aligned?

fivetran-jamie · 2026-09-11T15:24:29Z

+  using_report_date_fx_conversion:
+    type: boolean
+    value: false
+    description: "Enable to revalue foreign-currency balance sheet accounts using the exchange rate as of the report date, matching how QuickBooks Online calculates balance sheet conversions. Requires `quickbooks__home_currency` to also be set; without it, the exchange rate lookup cannot resolve and this feature has no effect."


Also should we note that this requires the exchange_rate table?

Yes absolutely!

fivetran-jamie · 2026-09-11T15:25:22Z

+
+Enable this feature if you want `converted_amount` on balance sheet accounts to match QuickBooks Online's own report-date revaluation approach. This does not affect profit and loss accounts, since period activity is already correctly valued at the transaction date.
+
+**This feature requires `quickbooks__home_currency` to also be set** (see [Configuring Your Home Currency for Multicurrency Support](#configuring-your-home-currency-for-multicurrency-support) above). The exchange rate lookup matches on your home currency as the conversion target, so without it the lookup never finds a matching rate and every account silently falls back to the legacy method.


Probably wanna note that this requires the exchange_rate table / using_exchange_rate to be true

Good point added

…bt_quickbooks into feature/exchange-rate

fivetran-avinash

@fivetran-jamie Ready for re-review!

fivetran-avinash added 2 commits August 28, 2026 18:09

Feature: Exchange rate addition

f381ec1

Reseed for new test scenarios

e856a6f

fivetran-avinash self-assigned this Sep 2, 2026

Merge origin/main (1.9.2 AP/AR fanout fix) into feature/exchange-rate

d1e4da9

Resolves conflicts in dbt_project.yml/integration_tests/dbt_project.yml (kept 1.10.0), account_data.csv (combined both branches' new seed accounts), and CHANGELOG.md (kept newest-first order: 1.10.0, 1.9.2, 1.9.1).

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Sep 2, 2026

fivetran-data-model-bot and others added 4 commits September 2, 2026 16:56

Generate dbt docs via GitHub Actions

eb648eb

Changelog/readme/quickstart.yml/test scenarios

b3670e4

:xi

e7a5c69

Merge branch 'feature/exchange-rate' of https://github.com/fivetran/dbt_quickbooks into feature/exchange-rate

quickstart var

805087b

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Sep 8, 2026

Generate dbt docs via GitHub Actions

83b3835

fivetran-jamie reviewed Sep 11, 2026

View reviewed changes

fivetran-avinash added 2 commits September 11, 2026 13:09

PR notes

0f3e8d4

Merge branch 'feature/exchange-rate' of https://github.com/fivetran/d…

62f0003

…bt_quickbooks into feature/exchange-rate

fivetran-data-model-bot removed the docs:ready Triggers the docs generator workflow. label Sep 11, 2026

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Sep 11, 2026

Generate dbt docs via GitHub Actions

1fd4331

fivetran-avinash commented Sep 11, 2026

View reviewed changes


		Enable this feature if you want `converted_amount` on balance sheet accounts to match QuickBooks Online's own report-date revaluation approach. This does not affect profit and loss accounts, since period activity is already correctly valued at the transaction date.

		This feature requires `quickbooks__home_currency` to also be set (see [Configuring Your Home Currency for Multicurrency Support](#configuring-your-home-currency-for-multicurrency-support) above). The exchange rate lookup matches on your home currency as the conversion target, so without it the lookup never finds a matching rate and every account silently falls back to the legacy method.

Uh oh!

Conversation

fivetran-avinash commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fivetran-avinash commented Aug 29, 2026 •

edited

Loading