Report streaming progress #540
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expede
force-pushed
the
report-streaming-percent
branch
from
35fbec6 to
9e5c8d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works! Cleaning up...
Closes #312
One small detail is that IPFS doesn't report the percentage, but "progress" (which is either bytes or blocks). We can estimate the percentage off of this, but given that IPFS doesn't give valid DAG sizes out of the box, it's very much a shot in the dark. As such, for now the backend will report the max progress across the cluster, and the SDK can chose what to do with that.
One strategy is to take the reported subgraph size from IPFS, and naively treat the progress as a portion of that. At worst the progress bar will jump from some low number to 100%, which is better than hanging at 99%