Skip to content

MoQ Endpoints#261

Merged
Karolk99 merged 5 commits intomainfrom
fce-3164/add-moq-endpoints
Apr 15, 2026
Merged

MoQ Endpoints#261
Karolk99 merged 5 commits intomainfrom
fce-3164/add-moq-endpoints

Conversation

@Karolk99
Copy link
Copy Markdown
Collaborator

Description

Describe your changes.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@Karolk99 Karolk99 requested a review from Copilot April 14, 2026 15:16
@linear
Copy link
Copy Markdown

linear bot commented Apr 14, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Vitest-based integration tests for the JS server SDK client, along with CI support to run them against a real Fishjam environment.

Changes:

  • Add Vitest configuration and an integration test suite covering core FishjamClient operations.
  • Introduce MoQ token support in the JS SDK (createMoqPublisherToken / createMoqSubscriberToken) and add the StreamId branded type.
  • Update the generated OpenAPI client (0.26.4) and add a GitHub Actions workflow to run integration tests.

Reviewed changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
yarn.lock Adds Vitest (and transitive deps like Vite/esbuild updates) to support the new test suite.
packages/js-server-sdk/vitest.config.ts Configures Vitest (timeout) for SDK tests.
packages/js-server-sdk/tests/client.test.ts Adds integration tests for authentication, rooms/peers, livestream token endpoints, and MoQ token endpoints.
packages/js-server-sdk/src/types.ts Adds StreamId branded type for MoQ token APIs.
packages/js-server-sdk/src/client.ts Adds MoQ API client wiring and exposes MoQ token helper methods.
packages/js-server-sdk/package.json Adds vitest dev dependency and a test script.
packages/fishjam-openapi/src/generated/index.ts Updates generated header version to OpenAPI doc 0.26.4.
packages/fishjam-openapi/src/generated/configuration.ts Updates generated header version to OpenAPI doc 0.26.4.
packages/fishjam-openapi/src/generated/common.ts Updates generated header version to OpenAPI doc 0.26.4.
packages/fishjam-openapi/src/generated/base.ts Updates generated header version to OpenAPI doc 0.26.4.
packages/fishjam-openapi/src/generated/api.ts Adds generated MoqApi/MoqToken and adjusts createTrackForwarding signature to require payload.
.github/workflows/integration-tests.yaml Adds CI job to run the new integration tests with secrets-provided credentials.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/js-server-sdk/tests/client.test.ts Outdated
Comment thread packages/js-server-sdk/tests/client.test.ts Outdated
Comment thread packages/js-server-sdk/src/types.ts
Comment thread packages/js-server-sdk/package.json Outdated
Comment thread .github/workflows/integration-tests.yaml Outdated
Comment thread packages/js-server-sdk/src/client.ts
Comment thread packages/js-server-sdk/tests/client.test.ts
Comment thread packages/js-server-sdk/tests/client.test.ts
Comment thread packages/js-server-sdk/vitest.config.ts Outdated
Comment thread packages/js-server-sdk/src/client.ts
Comment thread packages/js-server-sdk/package.json
@Karolk99 Karolk99 changed the title Add client api tests MoQ Endpoints Apr 15, 2026
@Karolk99 Karolk99 merged commit 47275f6 into main Apr 15, 2026
2 checks passed
@Karolk99 Karolk99 deleted the fce-3164/add-moq-endpoints branch April 15, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants