Conversation
There was a problem hiding this comment.
Pull request overview
Adds Vitest-based integration tests for the JS server SDK client, along with CI support to run them against a real Fishjam environment.
Changes:
- Add Vitest configuration and an integration test suite covering core
FishjamClientoperations. - Introduce MoQ token support in the JS SDK (
createMoqPublisherToken/createMoqSubscriberToken) and add theStreamIdbranded type. - Update the generated OpenAPI client (0.26.4) and add a GitHub Actions workflow to run integration tests.
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds Vitest (and transitive deps like Vite/esbuild updates) to support the new test suite. |
| packages/js-server-sdk/vitest.config.ts | Configures Vitest (timeout) for SDK tests. |
| packages/js-server-sdk/tests/client.test.ts | Adds integration tests for authentication, rooms/peers, livestream token endpoints, and MoQ token endpoints. |
| packages/js-server-sdk/src/types.ts | Adds StreamId branded type for MoQ token APIs. |
| packages/js-server-sdk/src/client.ts | Adds MoQ API client wiring and exposes MoQ token helper methods. |
| packages/js-server-sdk/package.json | Adds vitest dev dependency and a test script. |
| packages/fishjam-openapi/src/generated/index.ts | Updates generated header version to OpenAPI doc 0.26.4. |
| packages/fishjam-openapi/src/generated/configuration.ts | Updates generated header version to OpenAPI doc 0.26.4. |
| packages/fishjam-openapi/src/generated/common.ts | Updates generated header version to OpenAPI doc 0.26.4. |
| packages/fishjam-openapi/src/generated/base.ts | Updates generated header version to OpenAPI doc 0.26.4. |
| packages/fishjam-openapi/src/generated/api.ts | Adds generated MoqApi/MoqToken and adjusts createTrackForwarding signature to require payload. |
| .github/workflows/integration-tests.yaml | Adds CI job to run the new integration tests with secrets-provided credentials. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
czerwiukk
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)