Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the npm release workflow to avoid npm publish operating directly in a Yarn workspace context by packaging with Yarn first, then publishing the resulting tarball with npm (aligning with the stated motivation that npm doesn’t resolve Yarn workspaces correctly).
Changes:
- Add a
yarn packstep to generate apackage.tgzartifact forpackages/js-server-sdk. - Update the publish step to publish the tarball via
npm publish ./package.tgzinstead of publishing from the workspace directory contents directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pack with yarn, publish with npm.
Motivation and Context
NPM doesn't resolve yarn workspaces
Documentation impact
Types of changes
not work as expected)