Skip to content

FCE-3120 fix misconfigured publish#260

Merged
czerwiukk merged 1 commit intomainfrom
FCE-3120/fix-misconfigured-publish
Apr 13, 2026
Merged

FCE-3120 fix misconfigured publish#260
czerwiukk merged 1 commit intomainfrom
FCE-3120/fix-misconfigured-publish

Conversation

@czerwiukk
Copy link
Copy Markdown
Member

Description

Pack with yarn, publish with npm.

Motivation and Context

NPM doesn't resolve yarn workspaces

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link
Copy Markdown

linear bot commented Apr 13, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the npm release workflow to avoid npm publish operating directly in a Yarn workspace context by packaging with Yarn first, then publishing the resulting tarball with npm (aligning with the stated motivation that npm doesn’t resolve Yarn workspaces correctly).

Changes:

  • Add a yarn pack step to generate a package.tgz artifact for packages/js-server-sdk.
  • Update the publish step to publish the tarball via npm publish ./package.tgz instead of publishing from the workspace directory contents directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@MiloszFilimowski MiloszFilimowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@czerwiukk czerwiukk merged commit bb098c5 into main Apr 13, 2026
5 checks passed
@czerwiukk czerwiukk deleted the FCE-3120/fix-misconfigured-publish branch April 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants