Skip to content

[BHP1-1546] Add Optimized Contain Diagram#236

Open
Kcheung42 wants to merge 13 commits into
mainfrom
kc-BHP1-1546-add-optimized-contain-diagram
Open

[BHP1-1546] Add Optimized Contain Diagram#236
Kcheung42 wants to merge 13 commits into
mainfrom
kc-BHP1-1546-add-optimized-contain-diagram

Conversation

@Kcheung42
Copy link
Copy Markdown
Collaborator

@Kcheung42 Kcheung42 commented May 22, 2026

Purpose

  • Updated VMS to manage diagrams
  • Added new attributes to manage
  • Updated SIGContainAdapter::doContainRunWithOptimalResource to now also process a range of simulations after the optimal production rate has been computed and ensure getters for the points are now exposed in wasm
  • Updated Application to now display contain diagram

Related Issues

Closes BHP1-1546

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Open local vms and run migration script migrations.2026-05-11-add-optimized-contain-diagram

  2. In VMS, Navigate to Contain Module page

  3. Verify there is now a new accordion for Diagrams

  4. Verify there are now 2 contain diagrams, select edit to view the form of attributes a user can update

  5. Open local App and sync vms

  6. Open this worksheet:
    BHP1-1546.zip

  7. Re-run this worksheet

  8. Navigate to results page and verify there is a new diagram for the Production Rate vs Containment area diagram

Screenshot

image image

@rjsheperd
Copy link
Copy Markdown
Contributor

Impressive work! I appreciate how you also included the VMS work to make this more extensible in the future.

Testing the worksheet you provided looks good, and when I tested another worksheet to ensure backwards compatibility, that looked good as well (see: Surf&Contain-ContainmentDiagram-Issue.bp7.zip ).

Please take care of the following linting errors:

projects/behave_cms/src/cljs/behave_cms/components/common.cljs:124:26: warning: Shadowed var: cljs.core/type
projects/behave_cms/src/cljs/behave_cms/components/common.cljs:125:25: warning: unused binding opts
projects/behave_cms/src/cljs/behave_cms/components/common.cljs:223:49: warning: Shadowed var: cljs.core/type
projects/behave_cms/src/cljs/behave_cms/components/translations.cljs:35:16: warning: unused binding update-field
projects/behave_cms/src/cljs/behave_cms/components/translations.cljs:94:16: warning: Shadowed var: cljs.core/key
projects/behave_cms/src/cljs/behave_cms/submodules/subs.cljs:88:19: warning: Shadowed var: cljs.core/name

projects/behave/src/cljs/behave/components/results/diagrams.cljs

L88-123 - What do you think of turning this into a separate function that outputs [x-domain y-domain]? This seems like a bit of a tedious way to do this considering we're only interested in two outputs.

projects/behave/src/cljs/behave/worksheet/events.cljs

L824 - Should this use a translation key?

@Kcheung42
Copy link
Copy Markdown
Collaborator Author

hmm seems to be some missing inputs in save file you provided
image

I created a new file on dev
behave7-6a1749dc-f46d-41fa-891e-91747a220cc5.zip

This does indeed show me only half the ellipse on this branch:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants