Improve Wasm module linking facilities #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this improves the details about linking errors.
Robbepop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current usage of
wasmi::Linkerwith the more low-level and efficientInstance::new.The new linking facilities act lazily and only populate the externals buffer with what the module to be instantiated actually needs. In contrast the old linking facilities act eagerly and populate all available host functions onto the linker even if only a tiny fraction of them are in use.
This should improve performance and may even improve binary artifact size.
Caution: I was not able to locate end-to-end tests so I could not really test the changes. The old test is also no longer applicable to the new API. A new API that tests all paths would require a Wasm module that imports all available host functions.
This PR is best reviewed commit by commit.
A follow-up to further improve performance might be to re-use the
externalsbuffer for multiple instantiations if that's a common use case.