fix(nextjs): copy public/ into the standalone output - #683
Merged
Merged
Conversation
Next's standalone output only contains the public files it traced, and copyResources() skips a top-level entry that already exists in the output bundle -- so the rest of public/ was dropped and 404'd in production. Copy public/ explicitly, merging per file. copyResources() no longer handles it. Fixes #630
leoortizz
requested review from
Yuangwang,
abhis3 and
annajowang
as code owners
August 27, 2026 21:30
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Next.js adapter to reliably copy and merge the application's public directory into the standalone output directory, addressing cases where Next.js' standalone output is missing or only partially populated. It introduces a new copyPublicDirectory function, updates resource copying logic to prevent duplicate handling of the public directory, and adds corresponding unit and end-to-end tests. There are no review comments, and I have no additional feedback to provide.
Yuangwang
approved these changes
Aug 31, 2026
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next's standalone output only contains the public files it traced, and
copyResources() skips a top-level entry that already exists in the output
bundle -- so the rest of public/ was dropped and 404'd in production.
Copy public/ explicitly, merging per file. copyResources() no longer handles it.
Fixes #630