sm: make Inband-Security-Id configurable in Client CER#240
Merged
fiorix merged 1 commit intoMay 1, 2026
Conversation
Add InbandSecurityID field to sm.Client allowing callers to propose TLS (value 1) during CER/CEA exchange per RFC 6733 §5.3.1. The zero value preserves existing behavior (NO_INBAND_SECURITY). Fixes fiorix#239
Owner
|
LGTM. Minimal, backwards-compatible (zero-value preserves prior behavior), tests cover both the default and TLS=1 paths. Will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
InbandSecurityIDfield tosm.Clientallowing callers to propose TLS (value 1) during CER/CEA exchange per RFC 6733 §5.3.1. The zero value preserves existing behavior (NO_INBAND_SECURITY).Changes
InbandSecurityID uint32field tosm.ClientstructmakeCER()instead of hardcoded0RFC Reference
RFC 6733 §5.3.1 defines Inband-Security-Id AVP (code 299) with values 0 (NO_INBAND_SECURITY) and 1 (TLS).
All existing tests pass.
Fixes #239