Repository navigation
Fix Cgit parse_url truncating repository names - #2171
Merged
mergify[bot] merged 1 commit intoNov 13, 2026
Merged
mergify[bot] merged 1 commit into
mergify[bot] merged 1 commit into
Conversation
CgitBackend.parse_url used str.rstrip(".git"), which strips any trailing
run of the characters '.', 'g', 'i' and 't' instead of a single .git suffix.
As a result a repository named widget was imported as widge, cgit as c,
and git as an empty string. Remove only a literal .git suffix using
utilities.remove_suffix, and add regression tests for names ending in
those characters.
Fixes fedora-infra#2170
Signed-off-by: patelshivani2283-lab <patelshivani2283@gmail.com>
Contributor
|
This pull request is merged. |
Zlopez
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2170
Problem
CgitBackend.parse_urlusedstr.rstrip(".git"), which strips any trailing occurrences of the characters.,g,i, andtinstead of stripping only a literal.gitsuffix. As a result:cgit(e.g.https://git.zx2c4.com/cgit.gitorhttps://git.zx2c4.com/cgit) was imported as'c'.git(e.g.https://git.kernel.org/pub/scm/git/git.git) was imported as''(empty string).widgetwas imported as'widge'.editwas imported as'ed'.Solution
utilities.remove_suffix(url.rstrip("/"), ".git").split("/")[-1]to remove only a literal.gitsuffix.anitya/tests/lib/backends/test_cgit.pycovering repository names ending in those characters (cgit,git,widget,waiting).news/2170.bug.