Repository navigation
Fix relationship overlap warning - #2165
Merged
Zlopez merged 2 commits intoNov 13, 2026
Merged
Conversation
Contributor
|
This pull request is merged. |
Contributor
Author
|
@fedora-infra/anitya Could you please review this PR? |
Zlopez
requested changes
Nov 11, 2026
Zlopez
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the pull request.
Two things that have to be addressed:
- Fix the formatting so the tests are passing
- Missing news file (see https://anitya.readthedocs.io/en/latest/contributing.html#release-notes for more details)
Signed-off-by: patelshivani2283-lab <patelshivani2283@gmail.com>
Contributor
Author
|
Thanks for the review @Zlopez! I have formatted the code with Black and added the news fragment file |
Zlopez
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2164
Summary
Fixes the SQLAlchemy
SAWarningabout overlapping relationship definitions betweenProject.packagesandPackages.project.Changes
overlaps="project"to theProject.packagesrelationship inanitya/db/models.pyto silence the warning and prevent potential ORM conflicts.news/2164.bug.