Skip to content

Implementing Playsound command/module #9

Description

@yuuwe-n

Sorry, if the code is incomplete with placeholders, I created a fork to implement the command Playsound to see if the format was correct. I need to integrate the feather sounds with this module. This is my first time with contributing with open source, or any code base so I am very sorry if I done things wrong.

Also with my pull request, I am pretty sure all these Options could be replaced, but I don't know how to.

Done so far

  • Pretty much sourced command from gamepedia to create struct and impl
  • Added placeholders for Source

To Do

  • integrate position with sound placement
  • integrate volume (placeholded with f32 values)
  • integrate pitch (placeholded with f32 values)
  • integrate min_volume (placeholded with f32 values)
  • integrate with actually playing sound
  • acquire lists of sounds and music (i think we have to make our own sounds and music)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions