integer test; push revert librime 1.16.1#364
Merged
eagleoflqj merged 1 commit intomasterfrom May 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Appium coverage for integer config controls by exposing more accessibility identifiers in the SwiftUI config UI and introducing Python helpers for locating and manipulating those controls during tests.
Changes:
- Add accessibility identifiers for split-config sidebar entries, integer fields/steppers, and the reset button.
- Add Appium utility helpers for lookup, integer interaction, and global config reading.
- Add a new integer Appium test and refactor the existing boolean test to use shared helpers.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/config/SplitConfig.swift | Exposes sidebar item identifiers and switches labels to child descriptions. |
| src/config/IntegerView.swift | Adds identifiers for integer text fields and steppers. |
| src/config/FooterView.swift | Adds an identifier for the reset button. |
| appium/util/window.py | Adds a generic lookup helper for accessibility identifiers. |
| appium/util/integer.py | Adds integer-specific Appium interaction helpers. |
| appium/util/config.py | Adds a convenience reader for the global config file. |
| appium/util/button.py | Consolidates undo/redo lookup into a shared helper. |
| appium/util/boolean.py | Simplifies boolean helper code. |
| appium/test_integer.py | Adds end-to-end coverage for integer editing, undo/redo, validation, and reset. |
| appium/test_boolean.py | Refactors the boolean test to use the new shared helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.