adapt CMP0195#359
Merged
eagleoflqj merged 2 commits intomasterfrom Apr 12, 2026
Merged
Conversation
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
There was a problem hiding this comment.
Pull request overview
Updates the project’s CMake configuration to align Swift target handling with newer CMake behavior/policy (CMP0195), centralizing the target triple into a single variable.
Changes:
- Bump
cmake_minimum_requiredand define a Swift target triple (CMAKE_Swift_COMPILER_TARGET) derived from macOS deployment target + architecture. - Use the new target triple for global compile/link
-targetflags. - Update Swift helper CMake modules to use
CMAKE_Swift_COMPILER_TARGETinstead of the removedF5M_TARGET.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Defines deployment/target settings and applies -target flags globally. |
| cmake/InitializeSwift.cmake | Uses the shared Swift target triple when querying Swift target info. |
| cmake/AddSwift.cmake | Uses the shared Swift target triple when generating the C++ bridging header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.