ci: add test and lint jobs to ci#427
Conversation
04578d3 to
436333e
Compare
|
Thanks for merging the other PR, I've rebased and resolved merge conflicts for this one. |
|
Sorry, we currently have an internal repository for Squire as well that's not automatically synced to GitHub, and I forgot I had yet to push some of our latest commits. I had to do some futzing with the commits to ensure the internal repo keeps its history, so this now conflicts. I think this PR just needs to change the config files now. Regarding the dist/* files, I only update them when I'm doing a new release for |
436333e to
1429378
Compare
|
Hmm, I see. I am uncertain whether the internal repository is publicly accessible or not, but I'll assume it isn't since it's not linked anywhere and PRs are accepted directly on GitHub. A simpler approach might be to set up repository mirroring, and if you want to accept incoming PRs to GitHub, have an internal policy to merge locally and push to GitLab? The mirroring will forward merges to Mirroring:
This is not perfect either, but it's certainly less likely to lead to consistency issues than the current flow. (And avoids situations where you need to force-push to GitHub's master branch and sync things up.) Meanwhile, I've reset and reapplied my changes! |
Updates the GitLab CI pipeline so when PRs are submitted, they can be built, linted, and tested before being merged.
buildis to ensure the build process is defined correctly, and no errors occur during build.lintis because if you'll have the configuration defined anyway, it might as well be enforced. (A bit frustrating when doing a PR somewhere, and the main branch violates its own linting.)testwell you had this one before so you know what's up.This avoids issues, like what the repository has now, where linting is defined but
masterdoesn't pass the configured linting.npm run lintnpm run build,npm run lintandnpm run testall have no issues.When running
npm run build, it changes more than just what I modified in the source for linting because of the following commit where code was updated, but the build wasn't rebuild and committed:On your end it could be worth reviewing this.
/distdirecory meant to be in the repo?npm run build.This won't cover issues from GitHub unfortunately, but it will make it so these issues are more promptly handled when a PR is submitted on GitLab.
If would be best if this was reviewed and merged first, and then the other PR I submitted: