Skip to content

[CDTOOL-691] Better error reporting when JavaScript tools are missing #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jedisct1 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[CDTOOL-691] Better error reporting when JavaScript tools are missing #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
- feat(service/ratelimit): moved the `rate-limit` commands under the `service` command, with an unlisted and deprecated alias of `rate-limit` ([#1632](https://github.com/fastly/cli/pull/1632))
- feat(compute/build): Remove Rust version restriction, allowing 1.93.0 and later versions to be used. ([#1633](https://github.com/fastly/cli/pull/1633))
- feat(service/resourcelink): moved the `resource-link` commands under the `service` command, with an unlisted and deprecated alias of `resource-link` ([#1635](https://github.com/fastly/cli/pull/1635))
- feat(compute/build): improved error messaging for JavaScript builds with pre-flight toolchain verification including Bun runtime support
Copy link
Contributor

@kpfleming kpfleming Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the PR link to this line, following the example of the other CHANGELOG lines.


### Bug fixes:
- fix(compute/serve): ensure hostname has a port nubmer when building pushpin routes ([#1631](https://github.com/fastly/cli/pull/1631))
Expand Down
4 changes: 3 additions & 1 deletion pkg/commands/compute/build_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ func TestBuildJavaScript(t *testing.T) {
// default build script inserted.
//
// NOTE: This test passes --verbose so we can validate specific outputs.
// NOTE: npmInstall is required because toolchain verification checks for node_modules.
{
name: "build script inserted dynamically when missing",
args: args("compute build --verbose"),
Expand All @@ -529,8 +530,9 @@ func TestBuildJavaScript(t *testing.T) {
wantOutput: []string{
"No [scripts.build] found in fastly.toml.", // requires --verbose
"The following default build command for",
"npm exec webpack", // our testdata package.json references webpack
// The exact command depends on detected runtime (bun or node)
},
npmInstall: true,
},
{
name: "build error",
Expand Down
Loading
Loading