fix(index): preserve global option fields when route options are partial#398
Closed
ranjeetcao wants to merge 1 commit into
Closed
fix(index): preserve global option fields when route options are partial#398ranjeetcao wants to merge 1 commit into
ranjeetcao wants to merge 1 commit into
Conversation
Calling `Object.assign({}, global, processCompressParams(partialRoute))`
copies undefined values from the post-processed route object onto the
global params, silently nulling out fields like `onInvalidRequestPayload`,
`onUnsupportedRequestEncoding`, and `onUnsupportedEncoding` whenever
the route configures only one of them.
Fix the merge order: combine the raw user opts with the raw route opts
first, then pass the result through `processCompressParams` /
`processDecompressParams` once so each derived field is computed from a
coherent input rather than shallow-merged from already-processed objects.
Adds unit tests covering both decompress hook fallbacks and the
compress `onUnsupportedEncoding` fallback.
Closes fastify#340
Author
|
Closing as a duplicate of #397 (opened May 11, 6 days before mine — I missed it when scanning the issue). Apologies for the noise. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Object.assign({}, global, processCompressParams(partialRoute))copies undefined values from the post-processed route object onto the global params, silently nulling out fields likeonInvalidRequestPayload,onUnsupportedRequestEncoding, andonUnsupportedEncodingwhenever the route configures only one of them.Fix the merge order: combine the raw user opts with the raw route opts first, then pass the result through
processCompressParams/processDecompressParamsonce so each derived field is computed from a coherent input rather than shallow-merged from already-processed objects.Adds unit tests covering both decompress hook fallbacks and the compress
onUnsupportedEncodingfallback.Closes #340
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct