♻️ Use bcrypt directly instead of passlib #1539
Open
+8
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karta9821
force-pushed
the
feature/replace-passlib-with-bcrypt
branch
2 times, most recently
from
4f520da to
fb5e042
Compare
alejsdev
changed the title
karta9821
force-pushed
the
feature/replace-passlib-with-bcrypt
branch
from
fb5e042 to
80c7687
Compare
YuriiMotov
changed the title
YuriiMotov
approved these changes
Sep 3, 2025
Member
YuriiMotov
left a comment
YuriiMotov
left a comment
There was a problem hiding this comment.
LGTM
@karta9821, thank you!
Seems that passlib is dead, and sooner or later we have to take this step.
Changes are not breaking - previously created users can login.
ToDo:
- We can also remove
types-passlibdev dependency. - Before merging, I would regenerate and commit
uv.lock
github-actions
bot
added
the
conflicts
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
Member
|
So, we should probably be consistent here and also use |
|
@YuriiMotov Compared to replacing passlib with pwdlib:
The bcrypt library is already a transitive dependency through passlib, so this is essentially just removing the passlib wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The passlib library, previously used for password hashing in this project, is no longer actively maintained — its last update was over 4 years ago. This has been confirmed here: link to the issue.
To improve long-term security and maintainability, this PR replaces passlib with direct usage of the bcrypt library, which is actively maintained and widely used for secure password hashing.
Discussion: #1369