Skip to content

Comments

Grading and feedback PR [DO NOT MERGE]#23

Open
martypdx wants to merge 2 commits intofamilyrecipes:masterfrom
martypdx:master
Open

Grading and feedback PR [DO NOT MERGE]#23
martypdx wants to merge 2 commits intofamilyrecipes:masterfrom
martypdx:master

Conversation

@martypdx
Copy link

Good project, like how it came together.

  • Good job following Component architecture.
  • Overall code is clean and consistent
  • Fairly ambitious project, folders and files are well organized

Few things:

  • Not sure why Search uses hash, but Filter uses callback. Be consistent.
  • I like that used a function to handle applying the various options. Check out the file for example of how to remove duplication.
  • Moar tests. Tests are your friend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant