Create a function to round image into an ellipse#2456
Open
Yithis wants to merge 1 commit intofacebook:mainfrom
Open
Create a function to round image into an ellipse#2456Yithis wants to merge 1 commit intofacebook:mainfrom
Yithis wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
Author
|
Hope you have access to this link. I'm putting there my next changes, because as far as I know github do not support stacked PR. |
Contributor
Author
|
Next changes are here. |
oprisnik
approved these changes
Feb 22, 2021
Contributor
oprisnik
left a comment
oprisnik
left a comment
There was a problem hiding this comment.
Thanks for the PR, I'm going to move this to the sample app.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@oprisnik has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#2452
Test Plan
Code was checked by loading different images in showcase app. Best examples are here and here.