Updated BaseRunner.run API - #238
Conversation
|
Apologies for the number of CI runs, finally figured out how nox works to check locally in the future |
Anything that could be improved in the docs to make this clearer? |
|
I am new to nox so I did not grasp what nox was going to run in CI before pushing. I ended up using |
|
Are there any blockers for getting this merged? |
Co-authored-by: Tim Tetenberg <123412573+timmyte@users.noreply.github.com>
…llent` are set; added mutually-exlusivity check
…`; makes sure all captured Exceptions are rased in an `ExceptionGroup`
|
Changes look good to me, I originally started this to improve the ergonomics of creating the orca_mm binary in PR #224. With so many changes to how the runner works, do you think it would be best to restart this PR? |
Thanks for your feedback. |
…t the main process" This reverts commit ccffd1a
|
Had to make some changes. Units test pass fine now. |
Closes Issues
Closes #235
Description
capture,silent,stdout, andstderrcontrols inBaseRunner.runwith explicitstdout/stderrstream targets.Path, string paths, open text streams, callbacks,subprocess.PIPEcapture, and multiple destinations usingopi.execution.text_stream.TextStreamFanout.opi.execution.base.RunResultandopi.execution.run.SubprocessRunResultwith captured output, return-code helpers.stdin_str,capture, andsilentin favor ofstdinandstdout/stderrstream targets.Release Notes
Added
TextStreamFanoutstream-target fanout support for subprocess stdout and stderr destinations. (UpdatedBaseRunner.runAPI #238)BaseRunner.runAPI #238)Changed
BaseRunner.runto use explicit stdout and stderr stream targets. (UpdatedBaseRunner.runAPI #238)BaseRunner.runto return aRunResultinstead ofsubprocess.CompletedProcessorNone. (UpdatedBaseRunner.runAPI #238)Deprecated
stdin_str,capture, andsilentonBaseRunner.run. (UpdatedBaseRunner.runAPI #238)