Skip to content

Cubic Spline Periodic BC Not Implemented Error #155

Description

@akyul000

Hello,

Thank you for the library. I am trying to use
interpax.CubicSpline(s_kp, keypoints, axis=0, bc_type="periodic"),
but I am encountering a NotImplementedError.

According to the documentation (https://interpax.readthedocs.io/en/latest/_api/interpax.CubicSpline.html), periodic boundary conditions are supported. However, after inspecting the source code, it appears that periodic boundary conditions are explicitly not implemented (i.e., errorif(bc_type == "periodic", NotImplementedError) followed by bc_type = (bc_type, bc_type)).

I just wanted to bring this discrepancy to your attention in case it is unintentional or the documentation needs to be updated.

Best regards,
Ulas

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions