Optimize MLX kernel reuse and dense rate reductions - #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctzandbits &= bits - 1.Why
The previous Metal templates included
N_SAMPLES,N_CHANNELS,N_WORDS, andREFRAC_WIDTH. Every unseen chunk shape therefore produced a new kernel specialization and a large latency spike. The dense rate path also materialized a full cumulative-sum tensor and gather indices even when its completed bins were regular.Measurements
M4 Pro, MLX 0.31.2, explicit evaluation and synchronization:
The
ctzscan was neutral for sparse crossings and substantially faster for crossing-heavy inputs in the exploratory benchmark.Validation
uv run pytest -q: 155 passeduv run ruff check .: passeduv run ruff format --check .: passedgit diff --check: passed