Skip to content

[fingerprint] save db to pushed branch by default#352

Draft
mmichels-brex wants to merge 1 commit intoexpo:mainfrom
mmichels-brex:mmichels/issue-339-fingerprint-stacked-branches
Draft

[fingerprint] save db to pushed branch by default#352
mmichels-brex wants to merge 1 commit intoexpo:mainfrom
mmichels-brex:mmichels/issue-339-fingerprint-stacked-branches

Conversation

@mmichels-brex
Copy link
Copy Markdown

Why

Fixes #339.

Fingerprint DB entries were only saved to the repository default branch by default. That breaks stacked pull requests because a PR targeting feature-a can only restore caches from feature-a or the default branch, so entries created from pushes to feature-a were missing unless users explicitly configured saving-db-branch.

How

  • resolve the default fingerprint DB save branch to the current branch on push events
  • keep explicit saving-db-branch as the highest-priority override
  • apply the same behavior to both fingerprint and preview-build
  • add tests for the shared branch resolver and both save paths
  • document the new default behavior and the stacked-branch workflow requirement

Test Plan

  • pnpm exec jest --runInBand --watchman=false --forceExit
  • node ncc.js

@mmichels-brex mmichels-brex marked this pull request as draft March 24, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fingerprint always shows a diff on a branch based on another branch

1 participant