[fingerprint] save db to pushed branch by default#352
Draft
mmichels-brex wants to merge 1 commit intoexpo:mainfrom
Draft
[fingerprint] save db to pushed branch by default#352mmichels-brex wants to merge 1 commit intoexpo:mainfrom
mmichels-brex wants to merge 1 commit intoexpo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #339.
Fingerprint DB entries were only saved to the repository default branch by default. That breaks stacked pull requests because a PR targeting
feature-acan only restore caches fromfeature-aor the default branch, so entries created from pushes tofeature-awere missing unless users explicitly configuredsaving-db-branch.How
saving-db-branchas the highest-priority overridefingerprintandpreview-buildTest Plan
pnpm exec jest --runInBand --watchman=false --forceExitnode ncc.js