Conversation
|
Subscribed to pull request
Generated by CodeMention |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
=======================================
Coverage ? 53.66%
=======================================
Files ? 815
Lines ? 34671
Branches ? 7212
=======================================
Hits ? 18601
Misses ? 15989
Partials ? 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjchmiela
approved these changes
Mar 23, 2026
Contributor
sjchmiela
left a comment
sjchmiela
left a comment
There was a problem hiding this comment.
Sweet!
I think we can later talk about what we could do to make app_store_connect helpful!
Like, we could load app_store_connect.app that would comprise of preloaded app.attributes and for build-upload-related webhooks we could do app_store_connect.build_upload that would be attributes too, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're adding support for
on.app_store_connecttrigger in workflows. We need to enable users to access ASC context. This PR adds a basic schema, with just ASC app ID.How
Extend
StaticWorkflowInterpolationContextZby addingapp_store_connectschema with justeventobject containing justapp, with just theidproperty.Test Plan
Added unit test.