Skip to content

fix(eas-cli): limit only relevant provisioning profiles being validated with Apple#3526

Open
byCedric wants to merge 1 commit intomainfrom
@bycedric/eas-cli/skip-validating-invalid-provisioning-profiles
Open

fix(eas-cli): limit only relevant provisioning profiles being validated with Apple#3526
byCedric wants to merge 1 commit intomainfrom
@bycedric/eas-cli/skip-validating-invalid-provisioning-profiles

Conversation

@byCedric
Copy link
Member

Why

Just a tweak to not try to validate already known invalid or expired provisioning profiles.

How

  • We can't request "only valid provisioning profiles" from Apple, so we filter it instead based on the state.
  • When we make sure these provisioning profiles are valid, we skip the ones we know are invalid

Test Plan

  • eas build -p ios and go through the Apple account flow
  • eas credentials -p ios and try to manage Apple certificates

@github-actions
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@b162162). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...s/eas-cli/src/credentials/ios/appstore/bundleId.ts 33.34% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3526   +/-   ##
=======================================
  Coverage        ?   53.65%           
=======================================
  Files           ?      815           
  Lines           ?    34672           
  Branches        ?     7212           
=======================================
  Hits            ?    18601           
  Misses          ?    15990           
  Partials        ?       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant