Evolve credentials command to accept profile input and to output keystore json#3511
Evolve credentials command to accept profile input and to output keystore json#3511henriquevcosta wants to merge 3 commits intoexpo:mainfrom
Conversation
henriquevcosta
force-pushed
the
add-profile-name-to-credentials
branch
from
174f444 to
916dac0
Compare
|
/changelog-entry new-feature To support automations where Firebase projects need to be automatically configured, it is now possible to non-interactively obtain the hashes for EAS-managed credentials. |
|
Subscribed to pull request
Generated by CodeMention |
henriquevcosta
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 916dac0d8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| flags.json && | ||
| flags['non-interactive'] && | ||
| flags.platform === 'android' |
There was a problem hiding this comment.
The credentials command now uses EasNonInteractiveAndJsonFlags, whose shared flag contract says --json implies --non-interactive, but this branch requires both flags to be explicitly true. In a normal TTY session, eas credentials --platform android --json will skip this JSON path and drop into the interactive manager flow instead of emitting JSON-only output, which breaks script automation unless users add an extra undocumented requirement (--non-interactive).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
hm that's a good point! In this case should I just make the tool non-interactive as soon as the --json flag is passed? I don't know what other expectations are there around interactivity that it could break.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
1 participant
Why
Trying to automate the environment setup of an android app in a firebase project via terraform required
the SHA1 of EAS credentials, and there was no automated way of obtaining those.
How
I looked at the current implementation of features, including the
fingerprint:generatecommand, and tried to reuse that with a bit of help from Cursor.Test Plan
I tested it manually on my react native project and tried to implement a unit test. Let me know if more is enough
