Skip to content

[eas cli] Tar creation on windows: force the owner write bit on for directories #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sswrk wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −3
Open

[eas cli] Tar creation on windows: force the owner write bit on for directories #3489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3d902
[eas cli] tar creation on windows: force the owner write bit on for d…
sswrk Mar 10, 2026
aa912d3
add changelog
sswrk Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ This is the log of notable changes to EAS CLI and related packages.

### 🐛 Bug fixes

- Make directories marked as read-only in Windows writable when creating a tar, to prevent the cross-filesystem issues when extracting the tar. ([#3489](https://github.com/expo/eas-cli/pull/3489) by [@sswrk](https://github.com/sswrk))

### 🧹 Chores

## [18.3.0](https://github.com/expo/eas-cli/releases/tag/v18.3.0) - 2026-03-10
Expand Down
24 changes: 21 additions & 3 deletions packages/eas-cli/src/build/utils/repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,27 @@ export async function makeProjectTarballAsync(vcsClient: Client): Promise<LocalF

try {
await vcsClient.makeShallowCopyAsync(shallowClonePath);
await tar.create({ cwd: shallowClonePath, file: tarPath, prefix: 'project', gzip: true }, [
'.',
]);
await tar.create(
{
cwd: shallowClonePath,
file: tarPath,
prefix: 'project',
gzip: true,
...(process.platform === 'win32' && {
onWriteEntry(entry) {
// On Windows, read-only directories can have files created inside them.
// However, Node.js maps this to the `0o555` mode, which when moved to POSIX,
// prevents creating files inside them. This causes trouble on tar extraction.
// Hence, we're forcing the owner write bit on directories in Windows
// to avoid this issue.
if (entry.type === 'Directory' && entry.stat) {
entry.stat.mode |= 0o200;
}
},
}),
},
['.']
);
} catch (err) {
clearTimeout(timer);
if (spinner.isSpinning) {
Expand Down