fix: raise deploy per-asset size limit from 500MB to 4GB#3488
Open
fix: raise deploy per-asset size limit from 500MB to 4GB#3488
Conversation
Apple raised the App Store package limit to 4GB, but eas-cli still enforces a 2GB client-side limit on project archives. Apps bundling on-device ML models (LLaMA, Stable Diffusion, etc.) regularly exceed 2GB and hit this limit before reaching any server-side constraint. The upload path already uses streaming (fs.createReadStream), so there are no memory issues with larger archives. The server can still enforce its own limits independently via GCS signed URL constraints.
Apps with large on-device ML models need to deploy assets exceeding 500MB. Apple's App Store now supports packages up to 4GB, and the upload path already uses streaming (fs.createReadStream / Readable.from), so there are no memory issues with larger assets. The server enforces its own limits via 413 responses independently.
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_UPLOAD_SIZEfrom 500MB to 4GB incommands/deploy/index.tsworker/assets.tsto reflect the new limitfs.createReadStream/Readable.from) — no memory issuesRelated: expo/expo#43755 (fixes the
fs.readFile2GB Buffer limit inAFCClient.uploadFile())Test plan