Repository navigation
gateway: print unknown setup key once - #932
Open
sdivyanshu90 wants to merge 1 commit into
Open
sdivyanshu90 wants to merge 1 commit into
sdivyanshu90 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @SilenNaihin, could you please review this focused one-time credential-output fix whenever you have some time? |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
Contributor
Author
|
@kfallah Could you please review this PR whenever you have some time? Thanks |
Contributor
Author
|
Hi @SilenNaihin @kfallah, could you please review this PR whenever you have some time. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The unknown first-run setup recovery path printed the same one-time gateway key in both the
environment export and a later preservation sentence. Repeating a raw credential unnecessarily
increases its exposure in terminal scrollback and captured transcripts.
Closes #931
What
_emit_setup_credentialsas the only raw-key presenter.Validation
uv run --no-sync pytest -q exp/cli/gateway/serve_test.py -k 'not unbindable_port': passed,10 tests and 1 deselected
uv run --no-sync ruff check .: passeduv run --no-sync ruff format --check .: passed, 844 files already formatteduv run --no-sync ty check: passedThe deselected existing test opens an IPv4 listener, which this restricted workspace prohibits
with
PermissionError: [Errno 1] Operation not permitted. It does not exercise setup credentialpresentation.
Non-goals
This change does not alter key generation, storage, replacement, activation recovery, or the
successful first-run output path.