Migrate Docker builds to custom Dockerfiles and update exomiser script#628
Open
matthdsm wants to merge 3 commits intoexomiser:masterfrom
Open
Migrate Docker builds to custom Dockerfiles and update exomiser script#628matthdsm wants to merge 3 commits intoexomiser:masterfrom
matthdsm wants to merge 3 commits intoexomiser:masterfrom
Conversation
…g `exec-maven-plugin` for distroless and bash images.
…cript in the Docker image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new approach for building and running Docker images for the
exomiser-cliapplication, replacing the previous Jib-based method with custom Dockerfiles and Maven plugin configuration. The changes streamline the build process, provide more flexibility for runtime environments, and add a robust executable launch script for the CLI.Docker build and runtime improvements:
exomiser-bash.dockerfilefor a Bash-based runtime andexomiser-distroless.dockerfilefor a minimal distroless runtime, both including explicit build and copy steps for the CLI jar and dependencies. [1] [2]exec-maven-plugininpom.xmlto build Docker images using the custom Dockerfiles, supporting multiple tags and image variants. [1] [2]Executable script enhancements:
exomiserBash script for launching the CLI, which intelligently determines the Java executable, parses JVM and application arguments, and locates the jar file, improving usability and portability.Cleanup and deprecation:
enable_exomiser.shscript, which relied on Bash aliasing and Jib-generated files, as it is superseded by the new launch script and Docker setup.