Skip to content

Actually drop Rails < 7.0#574

Open
neilvcarvalho wants to merge 1 commit intoexcid3:mainfrom
neilvcarvalho:nc-remove-pre-rails-7-code
Open

Actually drop Rails < 7.0#574
neilvcarvalho wants to merge 1 commit intoexcid3:mainfrom
neilvcarvalho:nc-remove-pre-rails-7-code

Conversation

@neilvcarvalho
Copy link

Pull Request

Summary:
The v3.0.0 changelog mentions that Rails 6.1 support was dropped, which was done by removing it from the CI matrix. However, there's still some code that checks for versions lower than 7.0, and 6.1 is still included on the gemspec.

Related Issue:

Description:

This commit addresses that by changing the dependency version, and removing code that isn't needed anymore.

Checklist:

  • Code follows the project's coding standards
  • Tests have been added or updated to cover the changes
  • Documentation has been updated (if applicable)
  • All existing tests pass
  • Conforms to the contributing guidelines

Additional Notes:

@excid3
Copy link
Owner

excid3 commented Jan 12, 2026

Thanks @neilvcarvalho 👍

@excid3
Copy link
Owner

excid3 commented Jan 12, 2026

Need to run bundle exec appraisal update as well to update the gemfiles for CI to pass.

The v3.0.0 changelog mentions that Rails 6.1 support was dropped, which
was done by removing it from the CI matrix. However, there's still some
code that checks for versions lower than 7.0, and 6.1 is still included
on the gemspec.

This commit addresses that by changing the dependency version, and
removing code that isn't needed anymore.
@neilvcarvalho neilvcarvalho force-pushed the nc-remove-pre-rails-7-code branch from c6fd9d7 to 75cc968 Compare January 13, 2026 12:03
@neilvcarvalho
Copy link
Author

@excid3 I pushed an amended commit with the Appraisal updated lockfiles.

Tip: Appraisal recommends not checking in the lockfiles:

When using Appraisal, we recommend you check in the Gemfiles that Appraisal generates within the gemfiles directory, but exclude the lockfiles there (*.gemfile.lock.) The Gemfiles are useful when running your tests against a continuous integration server.

That way, each test matrix entry will resolve the version independently, solving some issues where the same gem is resolved to different versions on the same Rails version depending on the Ruby version. I had issues with factory_bot because of that and following that recommendation worked like a charm.

@excid3
Copy link
Owner

excid3 commented Jan 13, 2026

Appraisal isn't well maintained, so I only use it to generate the Gemfiles. We don't use it for anything else.

2.5.0 was released in July 2023, 3.0.0.rc1 in October 2024 and nothing since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants