Conversation
|
Thanks @neilvcarvalho 👍 |
|
Need to run |
The v3.0.0 changelog mentions that Rails 6.1 support was dropped, which was done by removing it from the CI matrix. However, there's still some code that checks for versions lower than 7.0, and 6.1 is still included on the gemspec. This commit addresses that by changing the dependency version, and removing code that isn't needed anymore.
c6fd9d7 to
75cc968
Compare
|
@excid3 I pushed an amended commit with the Appraisal updated lockfiles. Tip: Appraisal recommends not checking in the lockfiles:
That way, each test matrix entry will resolve the version independently, solving some issues where the same gem is resolved to different versions on the same Rails version depending on the Ruby version. I had issues with |
|
Appraisal isn't well maintained, so I only use it to generate the Gemfiles. We don't use it for anything else. 2.5.0 was released in July 2023, 3.0.0.rc1 in October 2024 and nothing since. |
Pull Request
Summary:
The v3.0.0 changelog mentions that Rails 6.1 support was dropped, which was done by removing it from the CI matrix. However, there's still some code that checks for versions lower than 7.0, and 6.1 is still included on the gemspec.
Related Issue:
Description:
This commit addresses that by changing the dependency version, and removing code that isn't needed anymore.
Checklist:
Additional Notes: