Repository navigation
Hotfix 8.10.2: Fix MCP list_projects date-time failures - #2733
Merged
Merged
Conversation
…#2730) * Write MCP dates as UTC and reject leading wildcards in project filters Older projects and stacks were stored without a time zone, so their dates serialized without a Z and failed the output schema's date-time format, breaking list_projects for MCP clients that validate structured output. A type-info modifier on the MCP serializer (and Exie's) now writes every DateTime as UTC without changing the generated output schema. list_projects with a leading wildcard such as name:*web* threw an unhandled Elasticsearch error; it now returns invalid_filter like search_stacks and search_events. * Add Arrange/Act/Assert sections to the new MCP tests Adapted for 8.10: - Adds the leading-wildcard regex, which main got from #2684, and applies the check in ValidateSearchAsync too, because 8.10 lacks #2684's stack/event leading-wildcard check. - Leaves McpToolResultFilter unchanged; the unknown-argument rejection it touched on main is not on 8.10. - Drops the McpEventCountGroup date arguments from the contract test; 8.10's group record has no date fields. (cherry picked from commit 6bdce3b) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 8dcd662)
(cherry picked from commit a9b201d)
* Keep other sessions signed in when a login or signup page loads Opening or reloading /login or /signup while signed in called the server logout. Every login shares one server token, so that signed out every other tab and device. A tab left on /login with an hourly auto-reload signed the user out again every hour. Only end the existing session for invitation links, which must be accepted as the invited user. * Sign in with OAuth without linking to the current session The login and signup pages no longer end an existing session on load, so a signed-in user could start an OAuth sign-in with their token attached. The API treats an authenticated external login without an invitation as account linking, which would attach the provider identity to the current user and revoke the other account's sessions. OAuth sign-in now sends no access token. Only the account settings page links a provider to the signed-in user, and it asks for that explicitly. Adapted for 8.10: - 8.10 still has the Facebook and Microsoft Live providers (main's #2403 replaced them), so facebookLogin and liveLogin take the same options object and the account settings page links them to the signed-in user too. - Keeps 8.10's token exchange request without #2403's expectedStatusCodes. - main's microsoft.test.ts and external-logins.svelte.test.ts cover main-only code, so their #2714 cases are ported into oauth-login.test.ts and a smaller external-logins.svelte.test.ts. - The new E2E test uses 8.10's /next paths. (cherry picked from commit a9f0336) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit f4a7c61)
Aspire.Hosting, Aspire.Hosting.AppHost, and Aspire.Dashboard.Sdk 13.6.0 and earlier have GHSA-f7vh-h5g3-7jrh (high) and GHSA-4g86-54fm-h9h8 (critical). NuGet audit warnings fail restore, so the branch could not build. 13.6.5 is the first patched release and matches main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AWSSDK.Extensions.CborProtocol, through Foundatio.AWS, resolves System.Formats.Cbor 9.0.5, which has a moderate advisory that fails restore. Pin the patched 9.x release; main pins 11.0.0, which needs .NET 11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for MCP
list_projectsandresolve_project, plus a few user-facing fixes frommain, without shipping the 9.0/.NET 11 work. Merging this does not deploy; pushing thev8.10.2tag does.Commits
createdUtc/lastEventDateUtchad noZand failed the output schema'sdate-timeformat. Clients that validate structured output rejectedlist_projectsandresolve_project/loginor/signupsigned the user out of every other tab and deviceWithDeno()release/8.10no longer restores: Aspire 13.4.6 has GHSA-f7vh-h5g3-7jrh (high) and GHSA-4g86-54fm-h9h8 (critical). 13.6.5 is the first fixed version and matchesmainmainpins 11.0.0, which needs .NET 11Differences from main
ExceptionlessMcpTools: adds the leading-wildcard regex, whichmaingot from Rebuild Exie chat on shadcn-svelte AI Elements #2684. It also rejects leading wildcards insearch_stacks/search_eventsfilters, which Rebuild Exie chat on shadcn-svelte AI Elements #2684 does onmain. Without that, a filter such astitle:*timeout*fails the whole Elasticsearch search instead of returninginvalid_filter.McpToolResultFilteris unchanged: the unknown-argument handling it touched onmainisn't on 8.10.McpToolContractTests: dropped theMcpEventCountGroupdate arguments, because 8.10's record has no date fields.main.facebookLoginandliveLoginget the same options object, and the account page links them to the signed-in user. The token exchange keeps 8.10's request, without Replace Windows Live authentication with Microsoft and remove Facebook login #2403'sexpectedStatusCodes.main'smicrosoft.test.tsandexternal-logins.svelte.test.tstest code that isn't on 8.10. Their Keep other sessions signed in when a login or signup page loads #2714 cases are ported to a newoauth-login.test.tsand a smallerexternal-logins.svelte.test.ts. The new E2E test targets/next.maingot there through the .NET 11 and OpenTelemetry upgrades, so this is a separate package and CLI bump. MessagePack stays on the 8.10 override (2.5.307).Verification
Run locally from this branch, with Elasticsearch in Docker. Only the .NET 11 runtime is installed locally, so tests ran with
DOTNET_ROLL_FORWARD=Major.dotnet buildof the solution (Release), with NuGet audit onExceptionlessMcpToolsTests, including legacy dates, leading and trailing wildcardsv8.10.1under .NET 11:OpenApiSnapshotTests(response order) and 3CloseInactiveSessionsJobTestscases (decimal precision)npm run validate(format, check, lint)npm run buildlist_projects/resolve_projectAfter merge
git tag v8.10.2 origin/release/8.10 && git push origin v8.10.2https://api.exceptionless.io/api/v2/aboutreports8.10.2.list_projectsandresolve_project(for exampleprojectName: "Sucker") against an organization with older projects.🤖 Generated with Claude Code