Repository navigation
Add a 14-day no-card free trial and replace the Free banner with timely notices - #2686
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 388b4f8f73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a415af16f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23330d590a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33a2358a02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a5e3e05bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dee3aa9af1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a44851e611
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 912f680930
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c334ab1d7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 611e15787b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9463ad644d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48b13524c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba300caeab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d8644f109
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00e2cd7571
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88b1f43700
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
niemyjski
left a comment
There was a problem hiding this comment.
The alias normalization and legacy membership fallback address the original alias and guessed-creator cases, and paid invitations now retain their previous behavior. Local revalidation still reproduced account-deletion trial renewal and both verification issues below.
Validation: 217 focused backend tests and 31 frontend tests passed; local staging-mode API and browser checks used Mailpit and a simulated Exie provider. Actual Stripe checkout and live AI were not exercised.
The existing mailbox-claim review finding is confirmed: start a trial, delete its organization and user, register the identical address again, and create an organization; the replacement receives EX_TRIAL again. Keep the claim independently of the deletable user record.
Other open feedback remains relevant: TrialExpirationJob still catches cancellation inside the batch and can page/renew afterward; the migration test does not check preservation of unrelated mappings/settings; and the invitation cache key remains constructed inline. Paid invite compatibility is fixed, but Free/trial invites still introduce 403/429 for formerly accepted requests, so the compatibility decision remains open while the PR says there are no breaking changes.
There was a problem hiding this comment.
Changes requested for two reproduced blockers:
- Account deletion resets the mailbox trial claim, allowing the same address to receive another trial. Preserve that claim independently of the deletable user record.
- Verification in another tab leaves the original Exie panel locked. Refresh the separate assistant-access query through the existing account-change path.
Before merge, explicitly decide whether the new Free/trial invite 403/429 responses are accepted compatibility changes and describe that decision accurately. The anti-abuse restrictions may be intentional; this is not a request to remove them.
Follow-up, not release blockers: misleading success text when another account's verification link is used, expiration-job cancellation handling, and bounded-memory billing statistics (downgraded to P3). No broad refactor is requested.
Verification: reviewed head 88b1f4370. On November 6, 35 focused backend tests, 31 frontend tests, and diff whitespace checks passed. Browser/API reproductions are from November 4 on that same head; E2E, Stripe checkout, and live AI were not rerun.
|
Addressed the review in bf287f7:
Replied on every thread. The ones that were questions (lock scope, 426, microdollars, Mailer, invite limit setting) are left open for you. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: daba9fb6d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
niemyjski
left a comment
There was a problem hiding this comment.
The previous trial-abuse and cross-tab verification blockers are addressed. Local dogfood confirmed a 14-day trial, Exie unlocking in the original tab after following the Mailpit link elsewhere, and a completed chat through a simulated local provider. Deleting the project, organization, and account, then registering the identical address now yields Free; Gmail aliases and disposable domains also yield Free. Cross-account verification now names both accounts. The new invite 403/429 behavior is explicitly documented as intentional.
Found and fixed one regression in 7ab11cb: a stale cached expired trial could overwrite an extension. The expiration job again reloads authoritative state under its existing billing lock; one failing-before/passing-after regression test was added. No broader refactor.
Validation: 282 focused backend tests (including API snapshots) and 43 frontend tests passed. Hosted CI is running. No additional merge-blocking finding from this pass. The shared daily cap resetting on Redis eviction/restart remains the previously documented maintainer decision; real Stripe checkout and live AI were not exercised.
Superseded by the November 9 re-review and local verification: the account-deletion and cross-tab verification blockers are fixed, invite compatibility is explicitly documented, and the new expiration regression is fixed in 7ab11cb.
…oses Trial claims now block another trial for Billing:TrialClaimRetentionDays (365 by default). An expired claim is renewed when the mailbox starts a new trial, and the trial expiration job deletes expired claims. A user's own earlier trial follows the same window. The change plan dialog lists the retention, event limit, and premium features a downgrade gives up. It never blocks the downgrade. Drop three blocked domains that couldn't be confirmed as disposable, and test that major mailbox providers are never blocked.
1968dde to
b4ed058
Compare
niemyjski
left a comment
There was a problem hiding this comment.
Re-reviewed the latest commit, 98185ea39. No remaining reproduced trial blockers.
Free is 1 user / 1 project. Expiry preserves data, suspends ingestion over capacity, and automatically recovers after excess members/invites/projects are removed. Finite/custom downgrade checks and admin trial-end controls are covered.
Validation: CI passed on this exact commit, including all backend and six browser shards and the flaky-test gate. Local browser expiry/recovery and 1,205 frontend tests passed. The full local backend run had five search-fixture startup failures; all five passed in isolation.
Replied to all 29 new comments and resolved 27. The two presentation-clock discussions remain follow-up review items; they make no API calls.
Deployment still requires the stable dedicated HMAC secret. Mailbox claims survive deletion for 365 days; the extra privacy document and undeployed conversion migration were removed.
The trial indicator and organization notices each ran their own minute timer to keep a local now state fresh. They now read clock.now, built on Svelte's createSubscriber: every reader shares one timer, it runs only while something reads it, and it also updates when the tab becomes visible again.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28c3505b5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
niemyjski
left a comment
There was a problem hiding this comment.
Preserved Eric’s shared-clock change in 28c3505 and added a regression for a daily trial notice returning in an open tab without refetching server state. Both clock threads are resolved.
Removed the additional HMAC secret/startup requirement introduced in 20df517. Claims again use the original normalized SHA-256 identifier; create-only uniqueness, concurrency protection, deletion-resistant eligibility, and 365-day retention remain. The privacy policy and setup notes now match this implementation. A plain hash permits offline comparison against guessed addresses; HMAC did not change API responses or trial enforcement.
Validation: 230 focused backend tests, 57 clock/WebSocket tests, frontend validation, and OpenAPI snapshots passed. Hosted CI is running on 94ffa7c.
The sidebar indicator and trial-ending notice now render "Trial ends in 3 days" with TimeAgo, which updates itself. The sidebar no longer needs the clock: the expiration job moves the organization to Free, which hides it. The notices still read the shared clock to decide when they show.
|
Swept the typography note across the PR: the trial settings load error now uses |
# Conflicts: # src/Exceptionless.Web/ClientApp/package-lock.json
niemyjski
left a comment
There was a problem hiding this comment.
One non-blocking support-workflow issue found during local dogfooding.
| })}>users and pending invitations</A | ||
| > | ||
| and <A | ||
| href={resolve('/(app)/organization/[organizationId]/projects', { |
There was a problem hiding this comment.
Follow-up (non-blocking): When a global administrator impersonates a suspended organization, this link redirects to the administrator's general project list, which does not include the impersonated organization's projects. I reproduced this locally; the organization owner sees their projects correctly. The redirect itself predates this PR, but it prevents the new recovery link from helping support in this case.
Eligible first organizations receive a 14-day, no-card trial with Medium features and Exie. Free allows one user and one project. Plan choices display finite user limits. Over-limit expiry suspends ingestion; removing excess users, invitations, and projects restores access.
Mailbox trial hashes survive deletion for 365 days; no extra secret is required. Migration 11 reapplies current limits to known plans. Invite capacity failures remain 426; Free/trial abuse controls can return 403/429.
Validation: CI passed at
df52bd52e, including backend and browser shards. Local browser testing verified trial recovery, saved notice dismissal, and cross-account verification with resend.Verification and implementation details
update-organization-plansadmin maintenance reapplies plan defaults while preserving billing prices. Migration 11 atomically updates known plans' user/project limits from the current plan at write time. It preserves unknown plans and concurrent billing/usage changes, skips unchanged documents, and does not guess creators from prior billing editors. Tests cross the 100-record page boundary and verify reruns, no-op sequence numbers, cache invalidation, and index mapping/settings preservation./api/v2/admin/change-planaccepts optionaltrialEndsUtc. Free/trial organizations expose Admin Actions → Set trial end date, including past dates for expiry testing. Paying subscriptions cannot be put on a trial.