fix(docker): drop the duplicate OPENROUTER_API_KEY entry from compose - #176
Open
Nordalux wants to merge 1 commit into
Open
fix(docker): drop the duplicate OPENROUTER_API_KEY entry from compose#176Nordalux wants to merge 1 commit into
Nordalux wants to merge 1 commit into
Conversation
#428 had already generalised the passthrough with `env_file: .env` and listed `OPENROUTER_API_KEY` alongside `OPENROUTER_MODEL`. My every-app#152 landed on top of it without a rebase and added a second entry for the same variable, so `environment:` now names it twice. Compose takes the last entry, and both resolved to `${OPENROUTER_API_KEY:-}`, so nothing was broken — but the duplicate is dead weight and the comment above my entry is now wrong: it claims nothing would forward the key, which stopped being true when `env_file` landed. Remove my entry and keep the one that sits with `OPENROUTER_MODEL`. `docker compose config` renders identical values for OPENROUTER_API_KEY and OPENROUTER_MODEL before and after.
HasimEmre
pushed a commit
to HasimEmre/open-seo
that referenced
this pull request
Jul 30, 2026
* Fix open-seo MCP auth discovery * Refine MCP marketing page route and copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
compose.yamlnamesOPENROUTER_API_KEYtwice underenvironment::This is my fault. #428 had already generalised the passthrough with
env_file: .envand listed the key next toOPENROUTER_MODEL. My #152 was merged on top a day later without a rebase, adding a second entry for the same variable.Nothing is broken: Compose takes the last entry and both resolve to
${OPENROUTER_API_KEY:-}, so the rendered value is unchanged and no warning is emitted. But the duplicate is dead weight, and the comment above my entry now says the opposite of the truth — it claims nothing would forward the key, which stopped being the case the momentenv_filelanded.Change
Remove my entry and its stale comment. Keep the one that sits with
OPENROUTER_MODEL.Verification
With a
.envcontaining both variables,docker compose configrenders the same values before and after:pnpm ci:checkpasses.Verified and tested by hand. The description was drafted with AI assistance — I'd rather let the diff do the talking than a long write-up.