Conversation
Postgres stores ISO checkedAt text while cutoffs always used the SQLite space-separated format, so 1d/7d/30d history windows compared wrong.
Contributor
|
Hey, Thanks for contributing! For the next few months, I'm going to stop accepting external PRs. Reviewing and testing them has been slowing down progress against the roadmap. Right now, the best way to contribute is through creating quality "Issues" which are easier for me to review and prioritize right now. Here is our updated contributing guide: https://github.com/every-app/open-seo/blob/main/docs/CONTRIBUTING.md Converting, this PR to an issue would be the best way to get it prioritized. You can use the the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
current_timestamp(YYYY-MM-DD HH:MM:SS).checkedAtas ISO text (YYYY-MM-DDTHH:MM:SS.MSZ). Lexicographicgte/lteacross those formats breaks same-day windows (<T), so 1d/7d/30d deltas and history can be wrong.How to review
rankTrackingTimestamps.ts—toRankTrackingCutoffTimestampsnapshotQueries.tsandrankTrackingResults.tsTest plan
pnpm exec vitest run src/server/features/rank-tracking/repositories/snapshotQueries.test.ts