Conversation
search-console-tools.ts opens with `/* eslint-disable max-lines */`. Three of its helpers — connectGscUrl, missingSelfHostedGoogleClientResponse, and describeGscError — are about Search Console connection state rather than about either tool in the file, so moving them out is what the disable was standing in for. No behaviour change: the functions move verbatim, the local ProjectAuthContext type moves with them as GscProjectAuthContext, and the file drops back under the cap so the lint suppression goes with it. Any further GSC-backed MCP tool now shares one definition of "not connected", "token expired", and the self-hosted setup nudge instead of restating them.
HasimEmre
pushed a commit
to HasimEmre/open-seo
that referenced
this pull request
Jul 30, 2026
…flineaccess-scope fix: support claude for mcp
Contributor
|
Hey, Thanks for contributing! For the next few months, I'm going to stop accepting external PRs. Reviewing and testing them has been slowing down progress against the roadmap. Right now, the best way to contribute is through creating quality "Issues" which are easier for me to review and prioritize right now. Here is our updated contributing guide: https://github.com/every-app/open-seo/blob/main/docs/CONTRIBUTING.md Converting, this PR to an issue would be the best way to get it prioritized. You can use the the |
ramonmnavarro-byte
pushed a commit
to ramonmnavarro-byte/open-seo
that referenced
this pull request
Aug 25, 2026
…flineaccess-scope fix: support claude for mcp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search-console-tools.tsopens with/* eslint-disable max-lines */. Three ofits helpers are about Search Console connection state rather than about either
tool defined in the file:
connectGscUrl— where to send someone who needs to connectmissingSelfHostedGoogleClientResponse— the self-hosted setup nudgedescribeGscError— theGscNotConnectedError/GscTokenError/GscApiErrorwordingMoving them into
gsc-shared.tsis what that disable comment was standing infor, and the file drops back under the cap so the suppression goes with them.
No behaviour change
The three functions move verbatim. The file-local
ProjectAuthContexttype moveswith them as
GscProjectAuthContext. Nothing else in the file changes beyond theimport block.
The payoff is for the next GSC-backed MCP tool: today it would have to restate
"not connected", "token expired", and the setup nudge, and the three copies would
drift. Downstream I have four such tools sharing this module, which is how the
extraction came up.
Test plan
knipis the meaningful one here — it would flag any of the three exports if themove left a caller behind.