Skip to content

Feat/#1019 maximum delivery radius - #1286

Open
vpeshev wants to merge 12 commits into
developfrom
feat/#1019-maximum-delivery-radius
Open

Feat/#1019 maximum delivery radius#1286
vpeshev wants to merge 12 commits into
developfrom
feat/#1019-maximum-delivery-radius

Conversation

@vpeshev

@vpeshev vpeshev commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

#1019
This is the way that i think it should be done on the serverside.
Tomorrow I will set the new feature to the front end and make a video of how it works

@vpeshev

vpeshev commented Jul 28, 2020

Copy link
Copy Markdown
Contributor Author

@evereq
https://www.loom.com/share/782938f2b3c346a9aa0baaa81f977621

If "max Delivery Radius" from admin/store/delivery areas/ is not setted -
the default radius is 50 000m - that can be seen at the beginning of the video (2 of the stores are inside the radius of 50km)

not sure what happened again with the commits

@vpeshev
vpeshev requested a review from evereq July 28, 2020 11:47
@vpeshev
vpeshev marked this pull request as ready for review July 28, 2020 11:49
@evereq

evereq commented Aug 4, 2020

Copy link
Copy Markdown
Member

@valiopld what you mean by "not sure what happened again with the commits"? What is the status of this? What about delivery zones etc? I want to see final video of how all that working when you finish

@CLAassistant

CLAassistant commented Feb 1, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ evereq
❌ vpeshev
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants