Skip to content
This repository was archived by the owner on Sep 6, 2018. It is now read-only.

Prevent Update Cycle On Unsortable Header Click #18

Open
mkaulig wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent Update Cycle On Unsortable Header Click #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/Table.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ you have. Stories make it possible to design better!
type alias Customizations data msg =
{ tableAttrs : List (Attribute msg)
, caption : Maybe (HtmlDetails msg)
, thead : List (String, Status, Attribute msg) -> HtmlDetails msg
, thead : List (String, Status, List (Attribute msg)) -> HtmlDetails msg
, tfoot : Maybe (HtmlDetails msg)
, tbodyAttrs : List (Attribute msg)
, rowAttrs : data -> List (Attribute msg)
Expand Down Expand Up @@ -212,13 +212,13 @@ defaultCustomizations =
}


simpleThead : List (String, Status, Attribute msg) -> HtmlDetails msg
simpleThead : List (String, Status, List (Attribute msg) ) -> HtmlDetails msg
simpleThead headers =
HtmlDetails [] (List.map simpleTheadHelp headers)


simpleTheadHelp : ( String, Status, Attribute msg ) -> Html msg
simpleTheadHelp (name, status, onClick) =
simpleTheadHelp : ( String, Status, List (Attribute msg) ) -> Html msg
simpleTheadHelp (name, status, attributes) =
let
content =
case status of
Expand All @@ -240,7 +240,7 @@ simpleTheadHelp (name, status, onClick) =
, darkGrey (if isReversed then "↑" else "↓")
]
in
Html.th [ onClick ] content
Html.th attributes content


darkGrey : String -> Html msg
Expand Down Expand Up @@ -448,29 +448,29 @@ view (Config { toId, toMsg, columns, customizations }) state data =
Html.caption attributes children :: thead :: withFoot


toHeaderInfo : State -> (State -> msg) -> ColumnData data msg -> ( String, Status, Attribute msg )
toHeaderInfo : State -> (State -> msg) -> ColumnData data msg -> ( String, Status, List (Attribute msg) )
toHeaderInfo (State sortName isReversed) toMsg { name, sorter } =
case sorter of
None ->
( name, Unsortable, onClick sortName isReversed toMsg )
( name, Unsortable, [] )

Increasing _ ->
( name, Sortable (name == sortName), onClick name False toMsg )
( name, Sortable (name == sortName), [ onClick name False toMsg ] )

Decreasing _ ->
( name, Sortable (name == sortName), onClick name False toMsg )
( name, Sortable (name == sortName), [ onClick name False toMsg ] )

IncOrDec _ ->
if name == sortName then
( name, Reversible (Just isReversed), onClick name (not isReversed) toMsg )
( name, Reversible (Just isReversed), [ onClick name (not isReversed) toMsg ] )
else
( name, Reversible Nothing, onClick name False toMsg )
( name, Reversible Nothing, [ onClick name False toMsg ] )

DecOrInc _ ->
if name == sortName then
( name, Reversible (Just isReversed), onClick name (not isReversed) toMsg )
( name, Reversible (Just isReversed), [ onClick name (not isReversed) toMsg ] )
else
( name, Reversible Nothing, onClick name False toMsg )
( name, Reversible Nothing, [ onClick name False toMsg ] )


onClick : String -> Bool -> (State -> msg) -> Attribute msg
Expand Down