feat: add depends_on to store service files for parallel
#1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
changed the title
depends_on to store service files for parallel
tedim52
changed the title
depends_on to store service files for paralleldepends_on to store service files for parallel
Collaborator
|
@tedim52 this good to be reviewed? |
| snooper_service = plan.add_service(snooper_service_name, snooper_config) | ||
| return snooper_el_engine_context.new_snooper_el_client_context( | ||
| snooper_service.name, | ||
| snooper_service.ip_address, |
Collaborator
There was a problem hiding this comment.
did you wanna do this?
Collaborator
Author
There was a problem hiding this comment.
yep this is intentional
Collaborator
Author
There was a problem hiding this comment.
actually i take that back - not for snooper engine, i think it can remain as snooper_service.name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the use of the
--parallelflag on Kurtosis v1.12.1, adepends_ontostore_service_filesto ensure thatstore_service_filesruns after exec instructions.This also adds
dns_nametoel_context. This allows distinguishing to usedns_name(service.name under the hood) orip_addr(service.ip_address). Using context.ip_addr will create a dependency under the hood whereasdns_namewon't