-
Notifications
You must be signed in to change notification settings - Fork 838
util: validate no leading zeroes7702 #4204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…js/ethereumjs-monorepo into util/bigint-bytes-fixes
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📦 Bundle Size Analysis
Generated by bundle-size workflow |
|
This is interesting. I can't find in EIP-7702 what value should be used for EDIT: linking this issue #4057 |
|
Ok, there was already so much discussion around this in the original issue, will leave it to you guys without adding some half-informed opinion. Guess you guys knows that these 0 issues are tricky in general, also in respect to RLP/No-RLP, please also keep the API backwards-compatible. |
This fixes issue #4057, where validateNoLeadingZeroes rejects [0] (single zero byte) because in strict RLP encoding, 0 should be an empty array []. However, for EIP-7702 authorization lists, chainId=0 (wildcard) and yParity=0 are valid values that may be encoded as 0x00.