feat: migrate to ep_plugin_helpers padToggle for User + Pad Wide settings#187
Merged
JohnMcLear merged 1 commit intomasterfrom May 7, 2026
Merged
feat: migrate to ep_plugin_helpers padToggle for User + Pad Wide settings#187JohnMcLear merged 1 commit intomasterfrom
JohnMcLear merged 1 commit intomasterfrom
Conversation
…ings The hand-rolled "Show Markdown" User Settings checkbox only let each user toggle markdown rendering for themselves. There was no way for the pad creator to set a pad-wide default and no entry in the Pad Wide Settings panel, so this plugin lived in only half of Etherpad's native settings model. Switch to padToggle: same single checkbox in User Settings, plus a parallel checkbox in Pad Wide Settings that broadcasts to every connected client and is honored by enforceSettings. The hand-rolled markdown_entry.ejs template, manual click wiring, and `settings.ep_markdown_default` plumbing are gone — the helper owns checkbox rendering, cookie persistence, broadcast sync, enforce, and i18n. Admins can still default the toggle via settings.json `ep_markdown.defaultEnabled = true` (the helper's standard config key). ep_plugin_helpers ^0.3.0 introduces padToggle. Pad-wide column degrades to a no-op on Etherpad cores without the ep_* padOptions passthrough patch (ether/etherpad#7698, < 2.7.4); user-side toggle is unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
padTogglefromep_plugin_helpers^0.3.0, which renders parallel checkboxes in both the User Settings and Pad Wide Settings panels and rides Etherpad's nativepadoptionsbroadcast/persist rail.enforceSettings, and i18n. The hand-rolledmarkdown_entry.ejstemplate, manual$('#options-markdown').on('click')wiring, and thesettings.ep_markdown_defaultadmin key are gone.settings.jsonep_markdown.defaultEnabled = true(the helper's standard config convention).ep_plugin_helpers/pad-toggle-server, client usesep_plugin_helpers/pad-toggle.Dependencies
ep_plugin_helpers^0.3.0 (introducespadToggle).ep_*padOptionspassthrough patch (feat(padOptions): pass plugin-namespaced ep_* keys through applyPadSettings etherpad#7698, >= 2.7.4). On older cores the pad-wide checkbox is hidden automatically and the user-side cookie toggle keeps working — no breakage for un-patched cores.Test plan
markdown.spec.tscontinues to click#options-markdown(same id; it isoptions-+ settingId).enforceSettingslocks user-side checkbox to the pad-wide value.DO NOT MERGE until the etherpad-lite ether/etherpad#7698 padOptions passthrough is available in the core version targeted for the pad-wide column.