build: commit pnpm-workspace.yaml with esbuild build approval#5
Merged
Merged
Conversation
pnpm v11 stores build-script approvals in pnpm-workspace.yaml under allowBuilds, separate from package.json's pnpm.onlyBuiltDependencies (which only declares which deps MAY have build scripts; the workspace file actually approves them). Without this committed, CI's 'pnpm install --frozen-lockfile' sees esbuild's postinstall as unapproved and bails with [ERR_PNPM_IGNORED_BUILDS], which exits non-zero and breaks the publish workflow's bump step. Generated via 'pnpm approve-builds --all'.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #4's
pnpm.onlyBuiltDependenciesin package.json wasn't enough — pnpm v11 also requires the actual approval to be persisted inpnpm-workspace.yaml'sallowBuilds:map.onlyBuiltDependenciessays 'these MAY have build scripts';allowBuildssays 'and yes, build them'.CI keeps failing with:
Generated via
pnpm approve-builds --all. The file pnpm wrote contains exactly:Test plan
pnpm install --frozen-lockfileruns esbuild's postinstall successfully now.ep_syntax_highlighting@0.1.xwill land on npm.🤖 Generated with Claude Code