-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Some deprecation warnings, formal and typo fixes #2505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ChatMemberXXX classes also redesigned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses deprecation warnings, formal improvements, and typo fixes across the codebase. The changes improve code quality by making abstract base classes explicit, adding proper constructor implementations, and cleaning up formatting issues.
- Converts several base classes to proper Abstract Base Classes (ABC) with explicit constructors
- Implements missing
__init__methods for ChatMember subclasses that previously usedpass - Fixes test data and removes trailing whitespace/empty lines
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| tests/test_types.py | Updates test data to use "left" status instead of "administrator" and removes trailing empty lines |
| telebot/types.py | Makes base classes abstract, implements missing constructors, adds deprecation warnings, and improves code formatting |
| telebot/apihelper.py | Adds explicit return statement and improves error handling with proper exception raising |
Comments suppressed due to low confidence (2)
coder2020official
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change self.class to type(self)
|
Otherwise lgtm |
|
To be sure you saw it: #2505 (comment) |
|
Yes, understood |
No description provided.