Skip to content

ESP-BSP benchmark action#751

Merged
PetrESP merged 4 commits into
masterfrom
petr/feat/bsp_metrics
May 19, 2026
Merged

ESP-BSP benchmark action#751
PetrESP merged 4 commits into
masterfrom
petr/feat/bsp_metrics

Conversation

@PetrESP
Copy link
Copy Markdown
Collaborator

@PetrESP PetrESP commented Apr 2, 2026

ESP-BSP Pull Request checklist

  • CI passing

Change description

Created a separate action which generates benchmark results
Removed benchmarks from build-run action

@PetrESP PetrESP self-assigned this Apr 2, 2026
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch 2 times, most recently from 1423688 to 4435827 Compare April 2, 2026 11:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Test Results

40 tests   40 ✅  3m 4s ⏱️
 6 suites   0 💤
 6 files     0 ❌

Results for commit cd16fe0.

♻️ This comment has been updated with latest results.

@PetrESP PetrESP linked an issue Apr 2, 2026 that may be closed by this pull request
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch 15 times, most recently from 55817ee to 2b70ccb Compare April 13, 2026 14:16
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch 7 times, most recently from cfa6b72 to 37bce90 Compare April 21, 2026 12:35
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch 3 times, most recently from b766ee1 to 5556740 Compare April 23, 2026 07:26
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch 5 times, most recently from be6efe6 to 439278b Compare April 28, 2026 14:56
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch from 439278b to 510bbea Compare May 5, 2026 07:54
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ PetrESP
❌ alekseiapa
You have signed the CLA already but the status is still pending? Let us recheck it.

@alekseiapa alekseiapa force-pushed the petr/feat/bsp_metrics branch 4 times, most recently from 8da389b to a5b4540 Compare May 8, 2026 03:09
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch 3 times, most recently from 4eed378 to eeb6d2f Compare May 13, 2026 08:04
@PetrESP PetrESP marked this pull request as ready for review May 13, 2026 08:04
@PetrESP PetrESP requested a review from espzav May 13, 2026 08:05
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch from eeb6d2f to 40e821c Compare May 13, 2026 09:09
Copy link
Copy Markdown
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrESP Thank you for this work! That's great!
I am not good person for make review of python and CI files. I looked at it and looks ok to me 👍

Comment thread conftest.py
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch from 40e821c to 1cb79a7 Compare May 18, 2026 11:03
@PetrESP PetrESP requested a review from tore-espressif May 18, 2026 11:57
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch from 1cb79a7 to c67f37a Compare May 18, 2026 14:16
Copy link
Copy Markdown
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrESP great work! I think that moving the benchmark into a separate workflow is the right idea. Also kudos for result uploading with esp-metrics-cli!

I'm leaving just nitpicks; nothing blocking

Comment thread SquareLine/gen.py
Comment thread .flake8
Comment thread .github/workflows/benchmark.yml
Comment thread .github/workflows/benchmark.yml Outdated
Comment thread .github/workflows/benchmark.yml
Comment thread .github/workflows/benchmark.yml
@PetrESP PetrESP force-pushed the petr/feat/bsp_metrics branch from c67f37a to aa18d58 Compare May 19, 2026 10:01
@github-actions
Copy link
Copy Markdown

⚠️ Build failure was ignored (continue-on-error enabled).

See details: View build logs

@PetrESP PetrESP merged commit 01405ee into master May 19, 2026
96 of 97 checks passed
@PetrESP PetrESP deleted the petr/feat/bsp_metrics branch May 19, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep history of LVGL benchmarks and build attributes (BSP-797)

5 participants