Make sure the presentation frame shows the intended buffer#64
Open
kqr wants to merge 1 commit intoeschulte:masterfrom
Open
Make sure the presentation frame shows the intended buffer#64kqr wants to merge 1 commit intoeschulte:masterfrom
kqr wants to merge 1 commit intoeschulte:masterfrom
Conversation
I have an after-make-frame-functions hook that switches new frames to
the *scratch* buffer, which broke epresent: it only ever showed an empty
presentation!
My current workaround is to define advice around epresent--get-frame which gets
the current buffer, calls epresent--get-frame, and then switches to the buffer,
as such:
(define-advice epresent--get-frame
(:around (actual-get-frame &rest args) epresent-frame-set-buffer)
(let ((presentation-buffer (current-buffer)))
(apply actual-get-frame args)
(switch-to-buffer presentation-buffer)
epresent--frame))
I realised, however, that epresent-run already gets the correct buffer – it just
doesn't switch to it after creating the frame! So that's what this fix
implements.
Author
|
Separately, one of the reasons this was hard to debug was that the "EPresent can That said, in this specific case, it would only guard against this particular error, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an after-make-frame-functions hook that switches new frames to
the scratch buffer, which broke epresent: it only ever showed an empty
presentation!
My current workaround is to define advice around epresent--get-frame which gets
the current buffer, calls epresent--get-frame, and then switches to the buffer,
as such:
I realised, however, that epresent-run already gets the correct buffer – it just
doesn't switch to it after creating the frame! So that's what this fix
implements.