fix: prevent Exp() from mutating input base parameter #18470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
approved these changes
Dec 29, 2025
Collaborator
AskAlexSharov
left a comment
AskAlexSharov
left a comment
There was a problem hiding this comment.
thank you. please also port https://github.com/ethereum/go-ethereum/pull/30636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Exp function in common/math/big.go was modifying the input base parameter despite the documentation explicitly stating "does not change base or exponent". This caused unexpected behavior when the same base value was reused after calling Exp(). Fixed by creating a copy of base before performing operations.