feat(auth): add --no-browser flag and stream auth stderr to broker log#23
Open
feat(auth): add --no-browser flag and stream auth stderr to broker log#23
Conversation
Document how to run the full epithet stack locally for end-to-end testing using oidc-provider-mock, including policy/CA/agent configuration and SSH with the Include wildcard pattern. Also adds task files for --run-dir and --browser flags.
Adds the --run-dir flag to the agent command, allowing users to specify a custom directory for broker socket and agent sockets instead of the default ~/.epithet/run. The flag supports ~ expansion for convenience. This is useful for testing scenarios where users want to avoid using their home directory. Closes task rcpb0pp0
Adds the --browser flag to 'epithet auth oidc', allowing users to specify a custom browser command for authentication instead of using the system default browser. The flag accepts a shell command string, with the URL appended (e.g., 'open -a "Google Chrome"' on macOS). This is useful when the system default browser is different from the user's preferred browser for authentication. Also updates the manual testing instructions in CLAUDE.md to use both --run-dir and --browser flags. Closes task cqaz0g0r
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-browserflag toepithet auth oidccommand for automated testing/headless environmentsNewAuth()constructor for proper dependency injectionos.Stderr.Sync()calls to ensure stderr is flushed when connected to a pipeChanges included
This PR includes 4 commits since
main:--run-dirflag to customize runtime directory--browserflag to specify browser for OIDC auth--no-browserflag for automated testingTest plan
go test ./pkg/auth/oidc/... ./pkg/broker/...)--no-browser🤖 Generated with Claude Code