Change OrcaWeightManager to use metric_names_for_computing_utilization first.#44196
Merged
adisuissa merged 4 commits intoenvoyproxy:mainfrom Apr 10, 2026
Merged
Change OrcaWeightManager to use metric_names_for_computing_utilization first.#44196adisuissa merged 4 commits intoenvoyproxy:mainfrom
OrcaWeightManager to use metric_names_for_computing_utilization first.#44196adisuissa merged 4 commits intoenvoyproxy:mainfrom
Conversation
…tilization for utilization. Signed-off-by: Misha Efimov <mef@google.com>
Member
Author
|
@markdroth FYI |
efimki
requested review from
adisuissa,
nezdolik,
tonya11en and
wbpcode
as code owners
Contributor
|
Thanks for taking care of this, @efimki! |
adisuissa
reviewed
Apr 1, 2026
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
High-level LGTM.
- AFAICT this is a breaking-change, and should have a runtime guard against it (as well as release notes).
- It seems that there are no tests that validate this ordering behavior. There should be probably be tests (with accompanying comments) if this ordering is required.
Signed-off-by: Misha Efimov <mef@google.com>
adisuissa
reviewed
Apr 2, 2026
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Minor nit, but otherwise lgtm.
Signed-off-by: Misha Efimov <mef@google.com>
Signed-off-by: Misha Efimov <mef@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This PR changes preferred order of ORCA endpoint metrics used to compute utilization in
OrcaWeightManagerused byClientSideWeightedRoundRobinlb policy to:metric_names_for_computing_utilization.application_utilizationcpu_utilizationAdditional Description:
The discussion on gRPC A114 has brought up the point that current order of ORCA endpoint metrics:
application_utilization->metric_names_for_computing_utilizationconfiguration ->cpu_utilizationmeans that if endpoint load report includesapplication_utilization, thenmetric_names_for_computing_utilizationconfiguration is completely ignored, which is not ideal.Changing preferred order to start with
metric_names_for_computing_utilizationstill allows fallback toapplication_utilizationandcpu_utilizationif no metrics are configured.Risk Level: Low
Testing:
bazel test //test/extensions/load_balancing_policies/common:orca_weight_manager_testbazel test //test/extensions/load_balancing_policies/client_side_weighted_round_robin:client_side_weighted_round_robin_lb_testProtected by:
envoy.reloadable_features.orca_weight_manager_use_named_metrics_firstRelease Notes: Yes